-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front-end routing #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't seem to get my `images` field working properly for some reason, need to get that figured out.
duncanmcclean
commented
May 14, 2021
…digital/runway into front-end-routing
This lets us add a 'Visit URL' button to the publish form.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces front-end routing functionality as part of Runway. Essentially, it hooks into the
DataRepository
, the same way entries/terms/etc do.Eventually, we'll use this foundation to implement live previews (#23).
Example
Say you have an e-commerce store and you're storing your products in the database. You probably at some point want to display those products on their own pages. Maybe something like
/products/slug-of-product
.Basically, this feature will allow you to do that. To use it, there's two things you need to do:
First, add a
route
to your model's configuration:In addition, you'll need to add the
HasRoutes
trait and theResponsable
interface to your Eloquent model.To Do
DataRepository
ourselves, extend on what's already there.Responsable
interface to their models, can we do that in our trait?Related Issues
Closes #25.