[4.x] Check the reference as part of recursive editing check #10012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the recursive editing check added in #9841, where it'd sometimes prevent editing unintentionally when it shouldn't be.
This issue can be seen in two scenarios:
1
, then try to edit term1
inline, it'd error out because the IDs are the same, even though they're different "things".Product
model and aManufacturer
model.1
, then try to edit manufacturer1
inline, it'd error out because the IDs are the same, even though they're different models.To fix this, we're now passing the item's "reference" to the publish container and checking it against the related item in the
RelationshipItem
component.Fixes #10005.