[5.x] Fix nested field path prefixes #10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksleight
changed the title
jacksleight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10280 introduced blink caching of the Fields objects in the replicator fields method. This took set indexes into account but not parent paths, which causes the wrong cached objects to be used when you have nested replicators.
This PR fixes that.
I also found an issue with the way field objects loaded from the repository are re-used. They have their parent index set when fetched, but since the same object is being returned it just updates that each time, resulting in one object with the last index set, rather than one object per index. I'm not sure if this is a result of the new blink caching or some other field caching that was introduced with v5, but cloning the object before setting the index fixes it.