Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cast_booleans configuration option to Radio fieldtype #2601

Merged
merged 3 commits into from Oct 7, 2020
Merged

Add cast_booleans configuration option to Radio fieldtype #2601

merged 3 commits into from Oct 7, 2020

Conversation

duncanmcclean
Copy link
Member

This pull request copies the cast_booleans configuration option from the Select fieldtype to the Radio fieldtype.

This PR closes #2558.

resources/lang/en/fieldtypes.php Outdated Show resolved Hide resolved
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jasonvarga
Copy link
Member

Just noticed this doesn't actually work when you try to use it in your templates. Same goes for the select fieldtype.

Merging anyway though, since it's the same amount of brokenness as the select fieldtype. Can fix that separately. Thanks!

@jasonvarga jasonvarga merged commit eee1244 into statamic:master Oct 7, 2020
@duncanmcclean duncanmcclean deleted the feature/radio-cast-booleans branch October 7, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fieldset with options true or false are converted to strings in v3
2 participants