Bring back smartypants #2689
Merged
Bring back smartypants #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to popular demand (at least 3 whole people 馃し). This PR brings back the
smartypantsmodifier and aStatamic\Support\Html::smartypants()method if you want to use it from PHP.Previously there was the ability to choose the 'behavior' but you had to pass in arbitrary constants which were ints and it was just a bit weird. I didn't include those. If someone needs them, we can think about a better way. Doing
{{ words | smartypants:2 }}doesn't make sense.Closes #2683
Closes #2139
Closes statamic/docs#203