Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mount' variable to Entries - Take #2 #3046

Merged
merged 6 commits into from Dec 23, 2020
Merged

Add 'mount' variable to Entries - Take #2 #3046

merged 6 commits into from Dec 23, 2020

Conversation

duncanmcclean
Copy link
Member

This PR implements a new mount variable to entries when they are augmented, as suggested by Jason on my previous PR.

This feels a lot cleaner than doing it directly on the Cascade class. Let me know if there's any changes you'd like me to make to this.

This PR implements #1352.

@duncanmcclean duncanmcclean marked this pull request as draft December 21, 2020 21:08
@duncanmcclean
Copy link
Member Author

I've converted this pull request to a draft until I get round to fixing the tests.

@duncanmcclean duncanmcclean marked this pull request as ready for review December 21, 2020 21:56
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted it so that if someone manually set a mount variable, that would take precedence. For instance, if someone wanted to recreate the v2 behavior, they might have added their own mount variable to the entry.

Otherwise, nice one.

@jasonvarga jasonvarga merged commit b3b4a17 into statamic:3.0 Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants