[3.1] File filtering caching #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he it to a property for speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do
$assetContainer->files()it would get the raw file listing which includes stuff in.meta,.gitignore,.DS_Store, etc and it would filter those out. It would do it every time you calledfiles().Users were reporting it would be slow when they have lots of assets. That makes sense, because if you have 5,000 assets, you'll have 5,000 hidden meta files. If you have all those assets spread out through many directories, then it'll also have all those directories. That'll give you over 10,000 items to filter though. Makes sense why it's slow.
This PR will make it so it only performs the filtering once per request by caching the listing to a property.