Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multisite entry blueprint logic #4465

Merged
merged 3 commits into from Oct 12, 2021

Conversation

jasonvarga
Copy link
Member

In #3786 the blueprint key was made to always be saved to the entry file to fix #3783.

In #4402, there were 2 cases where we were seeing the wrong blueprint being used:

  1. When you go to the create form and immediately change sites - that's because the blueprint query param was not passed along.
  2. When you change sites immediately after creating the first entry - that's because the wrong blueprint was saved to the localized entry. The blueprint() method was only looking at the blueprint yaml value on the origin entry. It wasn't taking into account when it was set as a property, which would be the case when localizing a freshly created entry.

Now the blueprint will only be saved to localized entries if it differs from the origin. 99% of the time it'll never differ - it doesn't really make sense. It'll only happen if you programmatically do it with $localization->blueprint('different')

Fixes #4402

@jasonvarga jasonvarga merged commit 86f8b7a into 3.2 Oct 12, 2021
@jasonvarga jasonvarga deleted the fix/4402-multisite-blueprint-dropped-on-change branch October 12, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant