Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix View methods #5020

Merged
merged 2 commits into from Jan 5, 2022
Merged

Fix View methods #5020

merged 2 commits into from Jan 5, 2022

Conversation

jasonvarga
Copy link
Member

The template method was treating a null argument as getter so you couldn't do View::make() without an argument.

Normally you'd do View::make('foo') but if you wanted to specify the template fluently (maybe because it's a long name and looked tidier) you couldn't. Now you can.

View::make()
  ->template('foo/bar/baz/qux')
  ->with(['foo' => 'bar']);

@jasonvarga jasonvarga merged commit af70e95 into 3.2 Jan 5, 2022
@jasonvarga jasonvarga deleted the fix/view-template branch January 5, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant