Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set min value on max_items & max_files config #5044

Merged
merged 5 commits into from Jan 25, 2022
Merged

Set min value on max_items & max_files config #5044

merged 5 commits into from Jan 25, 2022

Conversation

edalzell
Copy link
Contributor

Closes #5022

@edalzell
Copy link
Contributor Author

@jasonvarga is this the right approach for this issue?

@jasonvarga
Copy link
Member

LGTM

@edalzell edalzell marked this pull request as ready for review January 16, 2022 19:34
@jasonvarga
Copy link
Member

I noticed that adding min to the <input> prevents you from using arrow keys to navigate below 1, which is great, but you can still just type a negative number.

So I added validation too.

@jasonvarga jasonvarga merged commit dfa8777 into statamic:3.2 Jan 25, 2022
@edalzell edalzell deleted the fix/max-items-5022 branch January 25, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackmcdade jackmcdade Awaiting requested review from jackmcdade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_items allows negative values
2 participants
@edalzell @jasonvarga