Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track and remove nested hidden fields #5805

Merged
merged 24 commits into from Apr 14, 2022
Merged

Track and remove nested hidden fields #5805

merged 24 commits into from Apr 14, 2022

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Apr 8, 2022 •
edited

In #5101, we added tracking for hidden fields, so that users could use sometimes, required_if, etc. validation rules. That PR only handled fields at the top level though, and caused issues between nested fields and top level fields with the same handles. This PR adds proper handling of nested hidden fields.

  • Track and remove nested hidden fields on front end before submitting payload to server.
  • Ensure hidden field values (and nested hidden field values) are properly removed on PHP side before validating.
  • Refactor errorKey and errorKeyPrefix props/methods to fieldPath and fieldPathPrefix respectively.
    - We are now using error key for more than error handling, since those keys match payload structure.
  • Add test coverage.

jesseleite and others added 16 commits April 8, 2022 18:23
@jesseleite
Accept and track dottedKey instead of handle for nested field han…
0b0d58a 
…dling.
@jesseleite
Pass dottedKey using errorKey (for now, wip).
2893ac5
@jesseleite
Omit hidden values and nested values using dotted keys.
c49eca9
@jesseleite
Handle hidden fields within bard json values.
22b9843
@jesseleite
Add field conditions value Omitter.js helper class.
5d32ec6
@jesseleite
Track JSON-submitting fields.
570f13b
@jesseleite
Configure Bard fields as JSON-submitting (temporarily using error key…
8dc9608 
…, WIP).
@jesseleite
Remove old filtering logic in favour of more robust Omitter.js impl…
31bfee1 
…ementation.
@jesseleite
Fix non-existent key issues when deleting bard sets, etc.
318db14
@jesseleite
Ensure it properly handles null values vs undefined/missing values.
06251c0
@jesseleite
Make it a bit more forgiving.
ee77a46
@jesseleite
But this should only store unique field keys anyway.
dd641ed
@jesseleite
Move ‘filled’ logic from Field to Fields.
497c1bf
@jesseleite
Ensure validatableValues() gets called recursively.
672f417
@jesseleite
Pass tests again (should add tests for recursive fields next though).
037e154
@StyleCIBot
Apply fixes from StyleCI
450bd30
@jasonvarga jasonvarga mentioned this pull request Apr 13, 2022
Closed
@jesseleite jesseleite marked this pull request as ready for review April 14, 2022 18:06
@jasonvarga jasonvarga merged commit 4b6dd3c into 3.3 Apr 14, 2022
@jasonvarga jasonvarga deleted the track-and-remove-nested-hidden-fields branch April 14, 2022 21:50
@jasonvarga jasonvarga mentioned this pull request Apr 20, 2022
Closed
@jesseleite jesseleite mentioned this pull request Apr 20, 2022
Merged
buffalom pushed a commit to teamnovu/cms that referenced this pull request May 16, 2022
@jesseleite @StyleCIBot
@jasonvarga @buffalom
Track and remove nested hidden fields (statamic#5805)
c03047e 
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jason Varga <jason@pixelfear.com>
@rrelmy rrelmy mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field with name "title" in replicator causes error for "main" title
3 participants
@jesseleite @jasonvarga @StyleCIBot