Fix limit and offset on ordered query builders #5932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the limiting and offsetting from the query to the collection after the results have been retrieved.
For assets/entries/etc fields, the query gets wrapped in a decorator that'll apply the order after the results are retrieved. If you limit/offset, it would have already limited it on the query level before the decorator has a chance to change the order. This made using limit/offset on those types of fields sometimes output things in an unexpected/incorrect order.