Add placeholder and character_limit support to Bard #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht when no reading time)
|
Nice ones. I've added the character count to the field like you'd see in the text fieldtype.
|
jasonvarga
approved these changes
Aug 9, 2022
|
Oh nice! |
|
Hi @jacksleight! Thanks for your PR to make this feature available🙏🏻 How can I enable the character counter? Am I right, that this is not possible with e.g. |
|
Hey, this is only on the master branch at the moment, it hasn't been released yet. It requires Bard 2/TipTap 2 so will be part of Statamic 3.4. |
|
Oh, ok! Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds placeholder and character_limit support to Bard by implementing the official Tiptap 2 Placeholder and CharacterCount extensions:
https://tiptap.dev/api/extensions/placeholder
https://tiptap.dev/api/extensions/character-count
The placeholder CSS is taken from the Tiptap docs.
This PR is for Bard 2 / TipTap 2 and targets the master branch.
Closes statamic/ideas#826