Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite greeting in activation mail #7154

Merged
merged 2 commits into from Dec 1, 2022
Merged

Overwrite greeting in activation mail #7154

merged 2 commits into from Dec 1, 2022

Conversation

ruslansteiger
Copy link
Contributor

This PR enables to overwrite the greeting of the activation mail of the user.

Currently, you can invite the user via the control panel (cp/users/create). But I need to invite 30 users to my application and I want to personalize the invitation mail:

image

@what-the-diff
Copy link

what-the-diff bot commented Dec 1, 2022 •
edited

  • Added a new method to the ActivateAccount class called greeting()
  • The greeting() method is used in the body of an email sent when creating a user account, and allows you to customize that message.

jasonvarga
jasonvarga approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

I removed passing in the __('Hello!') fallback. If the email template was to change the greeting, this PR would have forced it to say Hello!. Passing in nothing works fine.

@jasonvarga jasonvarga merged commit 122952b into statamic:3.3 Dec 1, 2022
@ruslansteiger
Copy link
Contributor Author

Thank you. Have a fantastic day, Jason. 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruslansteiger @jasonvarga