Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revealer fields disappearing on save #7388

Merged
merged 18 commits into from Jan 27, 2023

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Jan 20, 2023

Closes #7384

@stephenmeehanuk
Copy link

Is this the same bug?

Hi, I've noticed something with the button fieldset. Not sure if it's intended or not.

This is a fresh install, done today.

The show controls toggle disappears if I try to turn it off?

Quick video shows what happens

https://www.youtube.com/watch?v=ZjmeUsz5dy0

Environment
Application Name: peak2023
Laravel Version: 9.48.0
PHP Version: 8.1.10
Composer Version: 2.4.1
Environment: local
Debug Mode: ENABLED
URL: peak2023.test
Maintenance Mode: OFF


Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 1
Antlers: runtime
Stache Watcher: Enabled
Static Caching: Disabled
Version: 3.3.65 PRO

Statamic Addons
studio1902/statamic-peak-commands: 1.16

@jesseleite
Copy link
Member Author

@stephenmeehanuk This is specifically fixing revealer fields disappearing when saving the publish form. Are you hitting cmd+s or ctrl+s to save in this video at all? If not, then this might be a separate bug, and maybe you could create a separate issue with detailed steps to reproduce, thanks!

@jesseleite jesseleite marked this pull request as ready for review January 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants