Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antlers runtime augment data collection values #7436

Conversation

JohnathonKoster
Copy link
Contributor

This PR fixes #7426 by augmenting instances of DataCollection if they are returned from tag callbacks, allowing the following to "just work":

{{ posts = { collection:blog } }}

{{ posts scope="post" }} {{ post:tags }} {{ title }} {{ /post:tags }} {{ /posts }}

@what-the-diff
Copy link

what-the-diff bot commented Jan 30, 2023

  • The reduceForAntlers method was changed to use the new RuntimeValues::resolveWithRuntimeIsolation()
  • A test for augmented assignment with tag results containing augmentable items was added
  • A test for tags returning collections resolving correctly was added

@jasonvarga jasonvarga merged commit ba0d53a into statamic:3.4 Feb 9, 2023
@jasonvarga jasonvarga deleted the antlers-runtime-augment-data-collection-values branch February 9, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terms within a scoped collection don't augment
3 participants