Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a Firefox Bug which makes inputs/textareas in draggable Bard Nodes unselectable #7525

Merged

Conversation

o1y
Copy link
Contributor

@o1y o1y commented Feb 12, 2023

Fixes #7447

This adds a workround to avoid a Firefox Browser Bug 739071. It seems before 3.4 the attribute draggable=true was not there, maybe something changed in tiptap 2.0 or ProseMirror.

Source: ueberdosis/tiptap#1668

…s when inside a draggable Bard Set or Bard Image
@what-the-diff
Copy link

what-the-diff bot commented Feb 12, 2023

  • In the Image.vue component, a new updated() method was added to set draggable attribute of $el
  • In the Set.vue component, an existing updated() method had its body changed and now sets draggable attribute of $el

@o1y o1y changed the title Add a workround to avoid a Firefox Bug which makes inputs/textareas in draggable Bard Nodes unselectable Avoid a Firefox Bug which makes inputs/textareas in draggable Bard Nodes unselectable Feb 12, 2023
@jasonvarga
Copy link
Member

Nice detective work

@jasonvarga jasonvarga merged commit ebcfd10 into statamic:3.4 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in bard set unselectable on firefox
2 participants