[4.x] Use default slug to get taxonomy entries count

[ryanmitchell]

This may be too simplistic a fix, but to get the correct entry count raised in #4493 we could just make sure we query by the default locale.

Fixes #4493

[ryanmitchell]

Yeah same test failures as on 5686. Something is definitely broken upstream.

[jasonvarga]

I was just working on this too and noticed we already have test coverage for this. But looks like the tests aren't set up right somehow since it passes before this change too.

My fix was the same as yours though 👍 Just figuring out what's wrong with the tests. The slugs in the localized versions aren't being used.

[ryanmitchell]

Cool. Want to close this in favour of yours?

[jasonvarga]

Nope leave this, I'll push to yours.

I'll sort out the unrelated test failures too.

[ryanmitchell]

Seems like the tests aren't ever checking for a count on a localised slug? Only ever a slug in the primary language.

[jasonvarga]

Yeah that's reason people are reporting #4493, and your PR fixes that.

But the tests were passing because the slug it looks like we're setting on the localizations don't ever actually make it to the term. If the localized term doesn't have a different slug, the bug never happens. No worries, I'll sort it out. Thanks!

[jasonvarga]

The unrelated test failures fixed over here: #8746