[4.x] Fix preferences when user has role via group #8957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We didn't actually have coverage for the role-based permissions being looped over. The tests only tested a single role. Since this PR was adding some complexity to that merging logic, I thought it would be a good idea to add a test. It's a complicated looking test, but I think it covers it. |
jasonvarga
approved these changes
Mar 7, 2024
jasonvarga
changed the title
jasonvarga
deleted the
fix/cp-nav-preferences-not-applied-when-user-has-role-via-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the CP Nav Preferences would not be applied to a user's Control Panel if they were assigned to a role via a user group.
Closes #7565.