Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix date replicator preview in more configurations #9093

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[4.x] Fix date replicator preview in more configurations #9093

merged 3 commits into from
Nov 30, 2023

Conversation

jasonvarga
Copy link
Member

Closes #9088

  • When you have time enabled and no value, it would now as null. Now it outputs nothing as expected.
  • Fix ranges being output as JSON. Now it outputs start - end.
  • Fix configured date format not being used. Now it does.

@jasonvarga jasonvarga merged commit 1325025 into 4.x Nov 30, 2023
34 checks passed
@jasonvarga jasonvarga deleted the date-preview branch November 30, 2023 15:39
@mmodler
Copy link
Contributor

mmodler commented Nov 30, 2023

Awesome!

@mmodler
Copy link
Contributor

mmodler commented Dec 1, 2023

Found one more issue with this PR, see #9088 (comment) Thanks!

@duncanmcclean duncanmcclean mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date field in replicator preview still looks buggy
2 participants
@jasonvarga @mmodler