Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix translations in nocache tag #9400

Merged
merged 3 commits into from Jan 26, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue with translations when using the {{ nocache }} tag.

Fixes #7893.

@jasonvarga jasonvarga merged commit 50b4cf4 into 4.x Jan 26, 2024
35 checks passed
@jasonvarga jasonvarga deleted the fix/translations-inside-nocache-tag branch January 26, 2024 17:59
@DanielDarrenJones
Copy link
Contributor

After upgrading to 4.47.0 our site hangs now on any page that uses the nocache tag - I think there might be something not quite right here, I have downgraded to 4.46.0 to confirm and that works as expected.

It only seems to be causing an error under really specific circumstances though, i'm struggling to track down what exactly that is though, as its only happening in one place in our codebase.

@jasonvarga
Copy link
Member

Are you using full measure static caching?

@duncanmcclean
Copy link
Member Author

Sounds like #9437.

@DanielDarrenJones
Copy link
Contributor

@jasonvarga yes in production, but caching was off locally and it was doing the same thing.

It does look like the other issue is the same issue - it's really hard to track this down though, for the meantime I have rolled back to 4.46.0

@duncanmcclean
Copy link
Member Author

@DanielDarrenJones The issue you're experiencing should be fixed by #9449.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nocache tag not playing nice with trans tag
3 participants