Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Rename route binding parameter to prevent overlapping #9415

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request changes the name of the route binding parameter that gets passed to the Product Updater controller to prevent issues with {product} overlapping with any custom app logic.

Fixes #8897.

@duncanmcclean duncanmcclean changed the title [4.x] Rename route binding parameters to prevent overlapping [4.x] Rename route binding parameter to prevent overlapping Jan 29, 2024
@jasonvarga jasonvarga merged commit 4d78829 into 4.x Jan 29, 2024
37 checks passed
@jasonvarga jasonvarga deleted the fix/overlapping-route-bindings branch January 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom route parameter resolution logic can overlap with CP routes
2 participants