[4.x] Fix issue with Set Previews in Bard #9422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually use them anywhere.
|
Is there a way to still show a preview now? Like, to designate a field to show? Because now my users are complaining about not knowing what the content is |
|
I do have "Preview" enabled on the fields I want, FYI |
|
This PR doesn't remove previews. If you're running into a problem, please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with Set Previews in Bard where fields returning
PreviewHtmlobjects would be converted into "normal" objects when the previews are cloned here.You can easily reproduce this with an Assets field & Forms field in a Bard set. When you change/remove the form, the preview for the Asset field in the set shows you the JSON rather than the expected preview output.
I've copied the fix for this from how we do the same thing on Replicator sets. I've also removed the
getReplicatorPreviewTextmethods from the Asset & List fieldtypes since they're no longer used.Fixes #9174.