Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Ensure template and termTemplate are accessed correctly in Taxonomy controller #9444

Conversation

ryanmitchell
Copy link
Contributor

Who knew this would keep coming back around.

This PR makes template and termTemplate public, as otherwise the fields in the TaxonomyController never have values.

Im sorry.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad I shouldn't have merged #9421 as-is.

I don't love making public properties in this case. We should probably tweak the controller from #9421 instead.

Maybe add hasCustomTemplate() and hasCustomTermTemplate() to Taxonomy and use those within the controller.

@ryanmitchell
Copy link
Contributor Author

Yep that feels nicer. Updated.

@ryanmitchell ryanmitchell changed the title [4.x] Make template and termTemplate public so they can be accessed in controller [4.x] Ensure template and termTemplate are accessed correctly in Taxonomy controller Feb 1, 2024
@jasonvarga jasonvarga merged commit 2116fa2 into statamic:4.x Feb 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants