[4.x] Add clear value button to popover date fieldtype #9478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnathonKoster
pushed a commit
to JohnathonKoster/cms
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of clients have been unsure how to clear a popover date fieldtype, as it's not super obvious that you have to delete the text or open the popover and deselect the date.
This PR adds clear buttons:
I wasn't 100% sure on where to place them. I think putting them in the fields looks tidiest, and it matches the select fieldtype's clear button, but it does feel a bit odd in time and range modes. At the moment the fields they appear in are the same ones that already clear the value when you delete the text, so there is some logic to it.