[4.x] Fix update counter #9479
Merged
[4.x] Fix update counter #9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix double AJAX calls
The update counter badge was performing 2 ajax request for every cp page request.
The vue component is rendered twice: once in the desktop nav and once in the mobile nav.
This is fixed now by using a Vuex store to keep track of the count and request. Only one of them will trigger the request.
Remove unnecessary caching boolean
The update count is cached. We had a boolean being passed to the ajax route which attempted to force a re-cache when necessary. This has never actually been working, and is unnecessary anyway. This PR removes that unnecessary code.