[4.x] Fix $authenticatedUser error with third-party addon events
#9490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Feb 8, 2024
duncanmcclean
changed the title
Event class to prevent authenticatedUser error$authenticatedUser error with third-party addon events
Done! |
jasonvarga
deleted the
remove-typehint-to-prevent-authenticated-user-error
branch
JohnathonKoster
pushed a commit
to JohnathonKoster/cms
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the
$authenticatedUserproperty tonullon our baseEventclass to prevent$authenticatedUser must not be accessed before initializationerrors.This error mostly seems to be happening for addons with their own events, which extend our base
Event. It also only happens when they're dispatching events with Laravel'seventmethod, rather than the::dispatchstatic method we normally use in Core.Fixes riasvdv/statamic-redirect#163.
Related Discord conversation: https://discord.com/channels/489818810157891584/1153390699161587823/1204384286052978689