[4.x] Clean up some event handlers #9500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielDarrenJones Do you think you could try this out? Since its just JS changes you'll need the assets. The |
|
@jasonvarga This does seem to make a noticeable difference, I can see the memory dropping back down now in the profiler when the asset browser is closed (by actually closing, or selecting), whereas before this was sticking up high. |
|
Thanks for testing. |
JohnathonKoster
pushed a commit
to JohnathonKoster/cms
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of some event handlers when the Vue components are destroyed.
This might help towards #9351