[4.x] Antlers: Corrects an issue with strict equality inside conditions #9621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-processing-tag-results
jasonvarga
deleted the
antlers-correct-strict-equality-regression-when-processing-tag-results
branch
duncanmcclean
added a commit
to duncanmcclean/simple-commerce
that referenced
this pull request
Mar 1, 2024
Fixed in statamic/cms#9621 but I want these tests to pass before that release is tagged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9615 by ensuring that context variables for the condition processor are evaluated with the correct settings, to prevent collapsing values too early (as was the case when double executing tags).
The linked issue manifests because the bugged behavior will return
1, causing the strict equality to fail.