[4.x] Only retrieve from origin blink cache when its not null #9661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9631 (and similar other reports) seem to be being caused by the load order on multi-sites, specifically when an origin is loaded after a descendant (eg
deloads beforeen).As we syncOriginalState on load, and that now includes the origins, it blinks a null value, which persists.
This PR changes the origin approach from using Blink::once() to using a get/set approach, checking if the value is not null and early returning it. This should give most of the performance once() wanted, but also allow a re-query when the value is null.
Closes #9631