[4.x] Users Listing: Allow for configuring default sort field & direction #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Mar 6, 2024
There was a problem hiding this comment.
This should probably also control the order of how the users tag sorts them too.
Right now it doesn't perform any default sort. It's just the order they are inserted into the Stache.
Having this generic config only control the control panel seems a bit odd.
You can set the default sort by adding a defaultOrderBy method to the Users.php tag class.
jasonvarga
approved these changes
Mar 7, 2024
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new config options to Statamic's
usersconfig file, allowing developers to configure the default sort field & direction for the Users Listing Table.At the moment, users are returned in ascending order by their
email. However, it's possible that developers may wish users to be ordered by other fields likelast_login_atinstead.