Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Remove manual Glide filenames #9913

Merged
merged 2 commits into from Apr 16, 2024
Merged

Conversation

jasonvarga
Copy link
Member

Since #9616 appends filenames automatically, there's no need to specify filenames manually anymore.

This was an undocumented relic of a feature that let you add a "fake" or "vanity" filename to the end of Glide URLs to be able to improve SEO. Now that's happening automatically rendering this feature irrelevant. This feature was broken in certain situations anyway, like if you tried to add filename="" to a glide tag where you are passing the path.

This is technically a breaking change since method signatures are changing. Also, you will need to remove filename="" from any glide tags otherwise nothing will be output.

@jasonvarga jasonvarga merged commit 6a91af9 into master Apr 16, 2024
31 checks passed
@jasonvarga jasonvarga deleted the remove-glide-manual-filename branch April 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant