Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Remove clear button of readonly date field #9993

Merged
merged 1 commit into from May 3, 2024

Conversation

PatrickJunod
Copy link
Contributor

Change:

Removed the "x" button from the date field / date range field when it is readonly.

Reasoning:

Removing this button eliminates the option to empty the date field. This resolves the issue where, if the date field is required but left empty, the page cannot be saved.

Example:

Before, we could click on the cross to clear this field, thus making it impossible to save the entry if the date field is required :
image

Before this fix:

image

After (removed the x button):

image

@PatrickJunod PatrickJunod changed the title Fix: remove clear button of readonly date field [4.x] Remove clear button of readonly date field May 3, 2024
@jasonvarga jasonvarga merged commit f7575f6 into statamic:4.x May 3, 2024
18 of 19 checks passed
@PatrickJunod PatrickJunod deleted the fix/read-only-date branch May 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants