Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect fact attr parameter is no longer used #107

Closed
duncanmcclean opened this issue Apr 27, 2020 · 2 comments
Closed

Reflect fact attr parameter is no longer used #107

duncanmcclean opened this issue Apr 27, 2020 · 2 comments

Comments

@duncanmcclean
Copy link
Member

Might be a good idea to update the documentation to reflect the fact that the attr parameter has been removed from the form:create tag and normal parameters can be used (like ID, classes, etc)

It caused some confusion on statamic/cms#1743. This would be the documentation page that needs updated.
@jasonvarga
Copy link
Member

Absolutely

@jasonvarga jasonvarga reopened this Apr 27, 2020
@edalzell
Copy link
Contributor

Might be useful to update the migration page with this info as well

edalzell referenced this issue in edalzell/docs Apr 30, 2020
@edalzell
attr is not a param anymore (part of #107)
44628d0
jasonvarga pushed a commit that referenced this issue Apr 30, 2020
@edalzell
attr is not a param anymore (part of #107) (#112)
48fc67a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonvarga @edalzell @duncanmcclean