sitemap.xml has too many homepage references

[benwellby]

We have installed the SEO Pro addon, everything is working great! However, the generated sitemap.xml outputs ~50 references to the homepage…

// this URL block is repeated ~50 times
<url>
    <loc>http://thoughtandmortar.local/</loc>
    <lastmod>2018-05-15</lastmod>
    <changefreq>monthly</changefreq>
    <priority>0.5</priority>
</url>

(Also tested on our 'live' server, same result)

In the addon settings, under Tools > SEO Pro > Site Defaults, I have disabled SEO Pro for any Collection that does not directly output it's own page/URL, which did not change the output.

All other page/URL references in the generated sitemap.xml a correct.

Has anyone else encountered this, or have any bright ideas on a possible fix?

:)

[jimblue]

Same problem here!

[benwellby]

@jimblue

I have also posted this topic on the forum at Statamic.

https://statamic.com/forum/3627-seo-pro-sitemap-xml-has-too-many-homepage-references

I will post back here if there is a response.

[moritzstuker]

Same here. Any update on this?

[nvmpy]

Are these homepage references just Entries within a Collection that has no route set, maybe?

seo-pro/SeoPro/TagData.php

Lines 59 to 68 in 86a7b21

	return $this->data->merge([
	'compiled_title' => $this->compiledTitle(),
	'canonical_url' => $this->model->absoluteUrl(),
	'home_url' => URL::makeAbsolute('/'),
	'humans_txt' => $this->humans(),
	'locale' => $this->locale(),
	'alternate_locales' => $this->alternateLocales(),
	'last_modified' => $this->lastModified(),
	])->all();
	}

canonical_url is populated via:

    /**
     * Get the full, absolute URL
     *
     * @return string
     */
    public function absoluteUrl()
    {
        return URL::makeAbsolute(
            URL::prependSiteUrl($this->uri(), $this->locale()),
            $this->locale()
        );
    }

where $this->uri() is null if there's no route set.

[jasonvarga]

Yeah, it's fixed in develop, gonna make a release today probably.

[jasonvarga]

This issue is most likely caused by a collection without a route.

For each of those collections you don't need URLs for, go into SEO Pro > Section Defaults > Your Collection then flick the sitemap enabled toggle.

[benwellby]

Thank you @jasonvarga

I can confirm downloading the latest version of SEO Pro solves the issue.

Perfect!

[benwellby]

There is still a slight issue…

I can't exclude a collection from both a generated sitemap 'and' the SEO Pro reports.

When setting a default for a section, let's call it "My Collection":

SEO Pro > Section Defaults > My Collection

I can't disable a section 'and' exclude it from the sitemap at the same time. This means a Collection Default is either enabled and the sitemap excluded, or disabled with the sitemap enabled.

Both can be on at the same time, but not off.

[benwellby]

Is anyone else experiencing this… in Section defaults, not being able exclude a collection from both a generated sitemap 'and' the SEO Pro reports?

[jackmcdade]

Are you running 2.10.7 and SEO Pro 1.1? I believe that's fixed now.

[benwellby]

Just tested this with both of the updates (although SEO Pro was version 1.1.1).

No joy. Can't have both excluded from reports and sitemap :(

[jasonvarga]

Just released 1.1.2 which fixes this.

[benwellby]

That did fix it @jasonvarga.

The sitemap.xml outputs only pages and collections as specified, and reports are now accurate.

When the Section Default is disabled the sitemap options still show as enabled. Functionally this change works, but could have a slightly improved UX (by disabling sitemap options too).

Great work chaps.

Thanks