Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphQL support for entry meta #207

Merged
merged 38 commits into from Jun 7, 2023
Merged

Add GraphQL support for entry meta #207

merged 38 commits into from Jun 7, 2023

Conversation

DanielDarrenJones
Copy link
Contributor

@DanielDarrenJones DanielDarrenJones commented Mar 2, 2022 •
edited by jesseleite

This PR adds the support for querying entry SEO data within GraphQL.

Screenshot 2022-03-02 at 22 30 52

Todo:

  • Ensure all fields are added
  • Clean up Field Types and add NonNulls
  • Add Site Field Type
  • Add Tests

@DanielDarrenJones DanielDarrenJones marked this pull request as draft March 2, 2022 22:48
@el-schneider
Copy link

Hey. Really looking forward to this. I think a field html that returns what the {{ seo_pro:meta }} renders could be usefull too. Unfortunately I know too little about laravel/statamic to help with any of that.

@AugmentBLU
Copy link

Is there an ETA on GraphQL support for this addon?

Thanks!

@jesseleite
Copy link
Member

Thanks for PR! Should be coming next week 👍

@jesseleite jesseleite changed the title [WIP] Add Graph QL Support [WIP] Add GraphQL Support Jun 2, 2023
@jesseleite jesseleite changed the title [WIP] Add GraphQL Support Add GraphQL Support Jun 2, 2023
@jesseleite jesseleite changed the title Add GraphQL Support Add GraphQL support Jun 2, 2023
@jesseleite jesseleite mentioned this pull request Jun 2, 2023
Merged
4 tasks
@jesseleite
Extract rendering of normalized meta HTML to reusable method.
ed52ebb
@jesseleite
Render same normalized meta html from graphql as we do in `{{ seo_p…
2ca5d9f 
…ro:meta }}`.
@jesseleite
Rename closure variable for consistency/clarity.
c81247b
@jesseleite
Hook up graphql provider for testing and assertGqlOk() macro.
3f0f1b5
@jesseleite
Test that user can get seo meta html through graphql.
d9dfb8d
@jesseleite
Test that user can get full seo cascade for custom rendering.
a30a6ca
@jesseleite
Only render line breaks between meta tags when using antlers/blade ta…
15af861 
…g, not in graphql.
@jesseleite
Move these customizations to setUp().
cc24390
@jesseleite
Add image seo to graphql tests.
60e0b30
@jesseleite
Test that optional() call we’re using to prevent errors when seo im…
9e09c94 
…age is not set.
@jesseleite
Test that alternate locale meta is properly output through graphql.
2e56be1
@jesseleite
Misc cleanup.
e408177
@jesseleite
Remove unused import.
7dac7ac
@jesseleite jesseleite marked this pull request as ready for review June 6, 2023 22:59
@jesseleite
Copy link
Member

Just a small note that we chose to avoid being too strict with NonNull requirements, because we don't want the whole entry/entries graphql output failing and taking down people's apps if SeoPro decides it is missing something, when it could just output null 👍

@jesseleite jesseleite changed the title Add GraphQL support Add GraphQL support for entry meta Jun 7, 2023
@jesseleite jesseleite merged commit 7bef8be into statamic:master Jun 7, 2023
12 checks passed
This was referenced Jun 7, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielDarrenJones @el-schneider @AugmentBLU @jesseleite