New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset manager - if you edit a non-image file it breaks #1106

Closed
dannyuk1982 opened this Issue Nov 15, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@dannyuk1982

dannyuk1982 commented Nov 15, 2016

Expected behaviour

Editing a non-image file (i.e. a PDF) either should not have an edit button, or should not break

Actual behaviour

A popup with "editing asset" appears with a loading graphic that never goes. The following is logged:

[2016-11-15 17:29:46] production.ERROR: Exception: Image [blah.pdf] does not actually appear to be an image. in /home/public_html/statamic/core/Imaging/ImageGenerator.php:178 Stack trace: #0 /home/public_html/statamic/core/Imaging/ImageGenerator.php(130): Statamic\Imaging\ImageGenerator->validateImage() #1 

Steps to reproduce

  1. Open Asset manager
  2. Click the edit pencil button on something like a PDF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment