You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 9, 2023. It is now read-only.
I don't know if this is a feature request - it certainly is no "Bug", but it is difficult for websites that are not in English:
You hardcoded the string "field" in the validate() method in core/Forms/Submission.
That makes it impossible to use the translation file validation.php to properly translate the validation error messages, because "field" sticks in there.
For example: my validation error is now:
"E-Mail field ist benötigt."
I would propose to leave that out there completely and let the translations handle the messages completely - of course that would be bad for people relying on that "field" there. Maybe you could kick the "field" string out of the method and make sure to add it in the translation files where is is needed after the :attribute ?
The text was updated successfully, but these errors were encountered:
I don't know if this is a feature request - it certainly is no "Bug", but it is difficult for websites that are not in English:
You hardcoded the string "field" in the
validate()
method incore/Forms/Submission
.That makes it impossible to use the translation file
validation.php
to properly translate the validation error messages, because "field" sticks in there.For example: my validation error is now:
"E-Mail field ist benötigt."
I would propose to leave that out there completely and let the translations handle the messages completely - of course that would be bad for people relying on that "field" there. Maybe you could kick the "field" string out of the method and make sure to add it in the translation files where is is needed after the
:attribute
?The text was updated successfully, but these errors were encountered: