Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #82

Open
11 tasks
epost opened this issue Oct 14, 2018 · 1 comment
Open
11 tasks

Refactor #82

epost opened this issue Oct 14, 2018 · 1 comment
Assignees

Comments

@epost
Copy link
Member

epost commented Oct 14, 2018

  • Document; add doc comments, etc.
    • Document Collage
  • lookup2
  • Use Foldable, etc. instead of List
  • eliminate Prelude.-prefixed function applications, e.g. Prelude.map (also consider Set.map)
  • align and indent stuff properly
  • Look at existentials, constraint kinds, ...
  • ADT instead of Stringly typed errors
  • Factor out common code
  • eliminate fromJusts if possible
  • ...
@epost epost self-assigned this Oct 14, 2018
epost added a commit that referenced this issue Oct 18, 2018
epost added a commit that referenced this issue Oct 18, 2018
epost added a commit that referenced this issue Oct 19, 2018
epost added a commit that referenced this issue Oct 19, 2018
epost added a commit that referenced this issue Oct 19, 2018
epost added a commit that referenced this issue Oct 19, 2018
wisnesky added a commit that referenced this issue Oct 19, 2018
Refactor. #82 (WIP, don't merge!)
epost added a commit that referenced this issue Oct 20, 2018
epost added a commit that referenced this issue Oct 20, 2018
epost added a commit that referenced this issue Oct 20, 2018
epost added a commit that referenced this issue Oct 20, 2018
epost added a commit that referenced this issue Oct 21, 2018
epost added a commit that referenced this issue Oct 21, 2018
epost added a commit that referenced this issue Oct 21, 2018
wisnesky added a commit that referenced this issue Oct 21, 2018
epost added a commit that referenced this issue Oct 23, 2018
epost added a commit that referenced this issue Oct 23, 2018
wisnesky added a commit that referenced this issue Oct 23, 2018
@wisnesky
Copy link
Contributor

  • use folds instead of recursion
  • the common idiom for (x in X) { updateInPlace(A,x), updateInPlace(B,x),...} gets 'shredded' into a collection of maps over X in Haskell in many places. These places should probably use the state monad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants