Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parser and serializer #71

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

adambabik
Copy link
Collaborator

Highlights:

  • Implement a new interface to communicate with VS Code.
  • Add a renderer which outputs a formatted markdown (check out runme fmt).
  • Better code organization.
  • Promised-based interface in the WASM component.
  • Switch to Go 1.19+.

Closes #64

Highlights:
- Implement a new interface to communicate with VS Code.
- Add a renderer which outputs a formatted markdown (check out `runme fmt`).
- Better code organization.
- Promised-based interface in the WASM component.
- Switch to Go 1.19+.

Closes #64
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambabik tested with https://github.com/stateful/baldaquin/blob/main/README.md (internal repo). The enumerated list is being turned into a series of 1s... I know this might not be trivial but I wonder if it's possible to parse them as is (text) vs an enumerated list?

@adambabik
Copy link
Collaborator Author

@sourishkrout that was a bug. I fixed it in 11d6a8d#diff-66475d0028b5262e2fe42a3dbb02c34e6e37f7270b1925b15d764a52e0d529cfR116.

@sourishkrout
Copy link
Member

I'd like to get this merged today (pending review stateful/vscode-runme#80) so we can "safely" merge and create pre-releases of runme/WASM without running the risk of release <> pre-release conflicts.

@adambabik
Copy link
Collaborator Author

@sourishkrout I can merge it now if you don't have any comments.

@sourishkrout
Copy link
Member

@sourishkrout I can merge it now if you don't have any comments.

let's merge. however, there is still more testing & polish to be done so let's be sure to limit to pre-releases for now.

@adambabik adambabik merged commit 11d6a8d into main Dec 8, 2022
@adambabik adambabik deleted the notebook-serializer-squashed branch December 8, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement NotebookSerializer interface with Markdown rendering from AST
2 participants