-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript 3.9.7 #1354
Conversation
🦋 Changeset is good to goLatest commit: ed9a277 We got this. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed9a277:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlCalzone's original repro LGTM with this change. Thanks for the quick turnaround!
packages/core/src/actions.ts
Outdated
@@ -106,6 +106,7 @@ export function toActionObject<TContext, TEvent extends EventObject>( | |||
const { type, ...other } = action; | |||
|
|||
actionObject = { | |||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you ignoring TS2783: 'type' is specified more than once, so this usage will be overwritten.
? I think the error's correct, in which case, you just need to move type
after ...exec
. If you disagree with the error, I'd love to know more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was trying to figure out what that error was asking for. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a bunch of your other @ts-ignore
s can also be removed, now that you're on 3.9.7. 😄
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
This PR does two things:
3.9.7
Action
type, based on guidance from Checking is slow in project consuming xstate types microsoft/TypeScript#39826cc. @amcasey