Improved .matches(value) inference for typestates containing union types as values
#1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cab12d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Jan 20, 2021
Andarist
force-pushed
the
typestates/improved-matches-inference
branch
from
796ba65
to
af6b7c7
Compare
|
Some type errors, otherwise LGTM |
|
Huh, gonna take a look - was running the full test suite locally and everything has passed 🤔 |
Andarist
force-pushed
the
typestates/improved-matches-inference
branch
from
09da0e9
to
cab12d1
Compare
davidkpiano
approved these changes
Jan 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported on Discord: https://discord.com/channels/795785288994652170/799416943324823592/801198150894223411