-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate createModel(...)
#3607
Conversation
🦋 Changeset detectedLatest commit: 771ca1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👇 Click on the image for a new way to code review
Legend |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 771ca1f:
|
RIP |
Oh no 🙊 |
@davidkpiano Typegen has never been reliable for me, it can never cover all the userland requirements and sometimes it just doesn't work. Is there any other way to allow the typing that createModel allowed, it's a lot nicer than passing generics to the assign method and doesn't require reliance on an extension. |
What specific things are you using |
@davidkpiano After giving this some more thought, I've moved to using typescript narrowing which achieves the same thing. |
The
createModel(...)
function is now marked as deprecated, as it will be removed in XState version 5. It is recommended to use Typegen instead.