Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Make all transitions internal by default #3756

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jan 9, 2023

This is just a WIP to open/continue the discussion about this change. I expect that many tests might fail since we definitely rely on "inferred" transition types in many of them - it will be easy to fix those tests up, I can do it after we agree on the change itself.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

🦋 Changeset detected

Latest commit: 4648499

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4648499:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Jan 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@davidkpiano
Copy link
Member

Let's go from internal: true/external: true to type: 'internal' or type: 'external'

@davidkpiano davidkpiano changed the title Make all transitions internal by default [v5] Make all transitions internal by default Jan 12, 2023
@Andarist Andarist marked this pull request as ready for review March 17, 2023 13:58
@davidkpiano
Copy link
Member

Are we renaming to reenter here or in a separate PR?

@Andarist
Copy link
Member Author

In light of https://discord.com/channels/795785288994652170/800812262473728000/1086277244147748936 , I would prefer to just do that rename in a quick follow-up - because it will touch a little bit more than just the name of the property

@Andarist Andarist merged commit 67d5761 into next Mar 17, 2023
@Andarist Andarist deleted the andarist/internal-transitions-by-default branch March 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants