-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] Make all transitions internal by default #3756
Conversation
🦋 Changeset detectedLatest commit: 4648499 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4648499:
|
Let's go from |
…nsitions-by-default # Conflicts: # packages/core/src/types.ts
Are we renaming to |
In light of https://discord.com/channels/795785288994652170/800812262473728000/1086277244147748936 , I would prefer to just do that rename in a quick follow-up - because it will touch a little bit more than just the name of the property |
This is just a WIP to open/continue the discussion about this change. I expect that many tests might fail since we definitely rely on "inferred" transition types in many of them - it will be easy to fix those tests up, I can do it after we agree on the change itself.