Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5] Action types #4180

Merged
merged 15 commits into from
Aug 22, 2023
Merged

[v5] Action types #4180

merged 15 commits into from
Aug 22, 2023

Conversation

davidkpiano
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7c332b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 9, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c332b8:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Aug 9, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Base automatically changed from v5/output-types to next August 17, 2023 13:37
Andarist
Andarist reviewed Aug 17, 2023
View reviewed changes
packages/core/src/StateNode.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add TAction to StateNode as well - but I kinda feel that state nodes should mostly be treated as internal data structures. Even if we expose them... people should just treat things as unknown etc as that's mostly useful for inspection, analysis etc and that kind of code is super generic. Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that StateNode should be internal, so it's your call whether to add it or not. Can always be added later

@Andarist Andarist merged commit 6b1646b into next Aug 22, 2023
3 checks passed
@Andarist Andarist deleted the v5/action-types branch August 22, 2023 15:47
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidkpiano @Andarist