-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TExpressionAction
to make pure
/choose
types stricter and tweak action
arg for inline actions
#4197
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7567523:
|
6bdf9d1
to
7567523
Compare
pure
/choose
and tweak action
arg for inline actionsTExpressionAction
to make pure
/choose
types stricter and tweak action
arg for inline actions
// entry: ({ action }) => {} | ||
// exit: assign(({ action }) => {}) | ||
action: typeof action === 'string' ? { type: action } : (action as any) | ||
// andarist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andarist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, u caught me marking my territory like a dog in a park - gonna remove this in a sec!
…in a machine (#4180) * Add TActions * Break stuff * YES * Named action tests * `TActions` -> `TAction` * bring back simplified action~ type * Introduce `TExpressionAction` to make `pure`/`choose` types stricter and tweak `action` arg for inline actions (#4197) * Introduce `TExpressionAction` * Tweak what action object gets provided to referenced and inline actions * avoid casting * Revert "avoid casting" This reverts commit 9333e8d. * Add changeset * reorder some tests * wrap tests in a block * add more runtime-oriented tests * add type-level tests * add extra tests for pure * fix choose and add extra test cases for it --------- Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
No description provided.