Move machine's output to top level
#4306
Conversation
🦋 Changeset detectedLatest commit: af34308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af34308:
|
| @@ -282,19 +258,13 @@ describe('output', () => { | |||
| }; | |||
| }, | |||
| context: { password: 'okoń' }, | |||
There was a problem hiding this comment.
What kind of password is this?
There was a problem hiding this comment.
😂 I forgot that i sneaked in this polish easter egg here in the past
|
Does this break existing behavior of |
Yes - I don't see how to maintain the backward compatibility in a sensible way here. This doesn't feel right: createMachine({
types: {} as { output: number },
initial: 'foo',
states: {
foo: {
type: 'final',
output: 'bazinga'
}
}
})Configuring some backwards compatible logic at type level (like if |
* Add warning * Update packages/core/test/json.test.ts Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> * tweak a test case * tweak code --------- Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
No description provided.