Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#19) - Remove prefix as a valid configuration #21

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

miguelcnf
Copy link
Contributor

Prefix is no longer used as an identification mechanism and it is obsolete by the existence of the namespace configuration which already prefixes a metric name.

Prefix is no longer used as an identification mechanism and it is obsolete by the existence of the namespace configuration which already prefixes a metric name.
Copy link
Contributor

@reistiago reistiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miguelcnf miguelcnf merged commit fcdd216 into master Sep 5, 2017
@miguelcnf miguelcnf deleted the 19-prefix-should-not-be-mandatory branch September 5, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants