Adds logic to automatically trim empty columns #912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @flexatone - this is a quick sketch to address an issue with xlsx Frame parsing. I don't have an up-to-date SF dev environment, so this is more meant as a proof of concept.
Basically, XLSX worksheets can easily report max_columns as being many more than expected. For example, you might have a worksheet with 3 columns, but
ws.max_columns
reports 1025, due to formatting. I know there is anadir
option, but it seems strange to support attempting to build impossible frames.If 1022 columns are simply EmptyCells, then the frame can never construct due to the repeated
None
's. My thought is to look at the header column, and automatically ignore all trailing EmptyCells.(I just realized my sketch doesn't account for index hierarchies, but oh well 🙃)
What are your thoughts?