-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CORS does not work when used with Basic Auth #343
Fix CORS does not work when used with Basic Auth #343
Conversation
Review changes with SemanticDiff. Analyzed 3 of 4 files. Overall, the semantic diff is 23% smaller than the GitHub diff.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, the PR has what we need to fix the issue.
In addition, I made some minor improvements to the src/cors.rs
as well as added/updated a few log entries and updated the CORS page mentioning the new allowed authorization
header.
However, as discussed. It would be great to add the necessary tests for the features used together. So feel free to add them here or let me know if you want to do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just please update the PR description and title accordingly. Also, link the issue that you are fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR fixes #336 when CORS is used together with Basic Auth.
The
Authorization
header is now added to thecors-allow-headers
list to work with the Basic Auth.Also, the server will allow
OPTIONS
requests without anAuthorization
header since it is not required according to the spec.Test cases will follow in a separate PR.